REFACTOR: Dotnet coreclr loading #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
==========================================
+ Coverage 82.48% 82.55% +0.07%
==========================================
Files 160 160
Lines 20987 21001 +14
==========================================
+ Hits 17311 17338 +27
+ Misses 3676 3663 -13 |
|
The pyaedt tests failed on linux when running with pyaedt-ci-6. I will conduct some changes on the VM to ensure it behaves correctly following our warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes allow one to leverage a dotnet installation at system level.
This is something that we should encourage as using
dotnetcore2prevents us from providing a conda recipe and also becausedotnetcore2requires openssl1.1 to be installed. It can't work with newer versions.