Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: plot method #900

Merged
merged 16 commits into from
Nov 20, 2024
Merged

REFACTOR: plot method #900

merged 16 commits into from
Nov 20, 2024

Conversation

maxcapodi78
Copy link
Collaborator

New plot method based on shapely.

@github-actions github-actions bot added maintenance Package and maintenance related dependencies Related with project dependencies testing Anything related to testing grpc-transition Changes that need to be included in gRPC transition labels Nov 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.77814% with 66 lines in your changes missing coverage. Please review.

Project coverage is 82.45%. Comparing base (500756e) to head (52dc671).
Report is 305 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
- Coverage   84.16%   82.45%   -1.71%     
==========================================
  Files         105      160      +55     
  Lines       17938    20954    +3016     
==========================================
+ Hits        15097    17278    +2181     
- Misses       2841     3676     +835
---- 🚨 Try these New Features:

@maxcapodi78 maxcapodi78 changed the title Refactor plot REFACTOR: plot method Nov 18, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 18, 2024
hui-zhou-a
hui-zhou-a approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 enabled auto-merge (squash) November 20, 2024 14:45
@maxcapodi78 maxcapodi78 merged commit 60777e3 into main Nov 20, 2024
24 checks passed
@maxcapodi78 maxcapodi78 deleted the refactor_plot branch November 20, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hui-zhou-a hui-zhou-a hui-zhou-a approved these changes

@svandenb-dev svandenb-dev Awaiting requested review from svandenb-dev

@SMoraisAnsys SMoraisAnsys Awaiting requested review from SMoraisAnsys

Assignees
No one assigned
Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation grpc-transition Changes that need to be included in gRPC transition maintenance Package and maintenance related testing Anything related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxcapodi78 @codecov-commenter @hui-zhou-a