FIX: get_pins_name_from_net #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMoraisAnsys
requested changes
Apr 30, 2024
Co-authored-by: Sébastien Morais <[email protected]>
hui-zhou-a
approved these changes
Apr 30, 2024
|
Generally, it is more usefull to just retrieve all the pins that are connected to a net, rather than checking if a specific pin belongs to this net. Nevertheless, with the new code you can do both. Also, i fixed the format of the returned name, because the component was not mentioned i.e. FCHIP-B11, but only B11 instead. Problem is that B11 also belongs in BGA-B11 and you cannot identify which of the two it references. |
SMoraisAnsys
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.