Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: stackup import xml #429

Merged
merged 35 commits into from
May 2, 2024
Merged

FIX: stackup import xml #429

merged 35 commits into from
May 2, 2024

Conversation

hui-zhou-a
Copy link
Collaborator

@hui-zhou-a hui-zhou-a commented Apr 29, 2024

@SMoraisAnsys @svandenb-dev this PR is dependent on #424.

@svandenb-dev with this implementation. Adding/removing signal layers is not allowed.

ring630 and others added 30 commits April 23, 2024 14:28
# Conflicts:
#	tests/legacy/system/test_edb.py
…ngs' into FIX-stackup-import-xml

# Conflicts:
#	tests/legacy/system/test_edb_stackup.py
@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Apr 29, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 1I
Total 0C 0H 0M 0L 1I
Secrets 0🔑

@hui-zhou-a hui-zhou-a changed the title Fix: stackup import xml FIX: stackup import xml Apr 29, 2024
@hui-zhou-a hui-zhou-a linked an issue Apr 29, 2024 that may be closed by this pull request
@SMoraisAnsys
Copy link
Collaborator

@ring630 What is the status of this PR ? Is it a draft (cf last commit) ? Should we wait for #424 to be merged before reviewing ?

@hui-zhou-a
Copy link
Collaborator Author

@ring630 What is the status of this PR ? Is it a draft (cf last commit) ? Should we wait for #424 to be merged before reviewing ?

Yes, merge this PR after #424

# Conflicts:
#	src/pyedb/configuration/configuration.py
#	tests/legacy/system/test_edb_stackup.py
@hui-zhou-a hui-zhou-a requested a review from SMoraisAnsys May 2, 2024 06:22
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a hui-zhou-a enabled auto-merge (squash) May 2, 2024 06:55
@hui-zhou-a hui-zhou-a merged commit bd06c01 into main May 2, 2024
20 checks passed
@hui-zhou-a hui-zhou-a deleted the FIX-stackup-import-xml branch May 2, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance edb.stackup.load support on xml
2 participants