FIX: Don't always remove AEDT project files #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove AEDT project-related files on EDB open (e.g. file.aedt and/or file.aedt.lock for file.aedb) only if Edb constructor is run with isreadonly False and remove_existing_aedt True.
ghost
requested review from
ghost
changed the title
|
@svandenb-dev BTW it looks like PyAEDT already has some logic to handle an existing .aedt file and open it if you try to open an edb.def or .aedb folder: https://github.com/ansys/pyaedt/blob/87739a9ea3223ee8e57d3d7c6ca7569a4f18eefe/pyaedt/application/Design.py#L1122 I guess we should leave it to users to understand when they have to remove the AEDT file before opening a modified EDB (with the warning I'm introducing here), what do you think? |
SMoraisAnsys
requested changes
Apr 25, 2024
Rename mocks to match mocked function names. Co-authored-by: Sébastien Morais <[email protected]>
Missed renaming one use of a mock in the previous commit, causing a test to fail.
SMoraisAnsys
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove AEDT project-related files on EDB open (e.g. file.aedt and/or file.aedt.lock for file.aedb) only if Edb constructor is run with isreadonly False and remove_existing_aedt True.
Fixes #412