FEAT: Raptor x simluation setup #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMoraisAnsys
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Nice job here, I just have a few remarks. I stopped half way with the if isinstance(...) remarks, there are some that I did not report.
About the docstrings, you might want to make them uniform because right now it feels like some times you speak to a user, other times a developer, and other times an efficient quick description (which i prefer tbh)
SMoraisAnsys
requested changes
Apr 24, 2024
hui-zhou-a
reviewed
Apr 25, 2024
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
hui-zhou-a
reviewed
Apr 25, 2024
Co-authored-by: Hui Zhou <[email protected]>
hui-zhou-a
reviewed
Apr 25, 2024
Co-authored-by: Hui Zhou <[email protected]>
For more information, see https://pre-commit.ci
SMoraisAnsys
changed the title
# Conflicts: # tests/legacy/system/test_edb.py
…raptor_x_simluation_setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RaptorX simulatiom setup support added. Works only with Release 2024.2 and higher.