D338: Doc/overall review_part2 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Overall doc review--edit of base RST files * Fix codespell herror * Apply suggestions from code review Co-authored-by: SMoraisAnsys <[email protected]> * Fix link target * add missing link targets * Fix file name in overall index.rst file * Fix link to Contribute topic in README * Submit RST file edits based on HTML rendering * Edit PY files in core/definition * Edits to definition PY files based on doc rendering Edits to geometry PY files * Fix code style issues * Edits to hierarchy PY files * Edits in inner PY files * Edits to PY files * Fix formatting issues from late Friday * Push first-round edits to PY files not yet reviwewd * Update src/ansys/edb/core/geometry/point3d_data.py * Fix code style issue * Format properties and defaults consistently * Fix tagging mistake * Fix another tag * Fix bad role tagging * Clean up of PY files through middle of geometry directory * Changes through geometry folder * Additoinal edits based on visual rendering of additional PY files * Edit RN RST file * Fix one more tag issue --------- Co-authored-by: SMoraisAnsys <[email protected]>
drewm102
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following default branch rename, the following change was merged into old default (develop) instead of the new one (main).
This change merges them back into new default (main) branch