Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D338: Overall doc review #337

Merged
merged 9 commits into from
Dec 14, 2023
Merged

D338: Overall doc review #337

merged 9 commits into from
Dec 14, 2023

Conversation

PipKat
Copy link
Member

@PipKat PipKat commented Dec 12, 2023 •
edited by hiro727
Loading

resolves #338

@PipKat PipKat requested a review from hiro727 as a code owner December 12, 2023 22:12
@PipKat PipKat changed the title Overall doc review Overall-doc-review Dec 12, 2023
hiro727
hiro727 previously approved these changes Dec 13, 2023
View reviewed changes
@hiro727 hiro727 requested a review from bwnedrud December 13, 2023 06:52
@hiro727 hiro727 changed the title Overall-doc-review D338: Overall doc review Dec 13, 2023
@hiro727 hiro727 dismissed their stale review December 13, 2023 07:01

Missed reviews on the failing checks

SMoraisAnsys
SMoraisAnsys requested changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes to the urls

README.rst Outdated Show resolved Hide resolved
doc/source/api/release_notes.rst Outdated Show resolved Hide resolved
doc/source/contribute.rst Outdated Show resolved Hide resolved
bwnedrud
bwnedrud reviewed Dec 13, 2023
View reviewed changes
README.rst Outdated Show resolved Hide resolved
bwnedrud
bwnedrud reviewed Dec 13, 2023
View reviewed changes
doc/source/contribute.rst Outdated Show resolved Hide resolved
PipKat
PipKat commented Dec 13, 2023
View reviewed changes
README.rst Outdated Show resolved Hide resolved
PipKat
PipKat commented Dec 13, 2023
View reviewed changes
doc/source/contribute.rst Outdated Show resolved Hide resolved
@hiro727 hiro727 merged commit b03380e into develop Dec 14, 2023
15 checks passed
@hiro727 hiro727 deleted the doc/overall_review branch December 14, 2023 02:28
@PipKat PipKat mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@drewm102 drewm102 drewm102 approved these changes

@bwnedrud bwnedrud bwnedrud approved these changes

@hiro727 hiro727 hiro727 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open sourcing: Documentation reviews
5 participants
@PipKat @hiro727 @bwnedrud @drewm102 @SMoraisAnsys