Skip to content

Commit

Permalink
D104: Install grpc prior to running develop install (#105)
Browse files Browse the repository at this point in the history
* D104: Up the version of grpc

* install core dependencies first

* install deps before develop hook

* add missing requirements file
  • Loading branch information
hiro727 authored Sep 8, 2022
1 parent 5125cb6 commit bbeee71
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/ci_cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip flit
python -m pip install -r protos/requirements/requirements_build.txt
python -m pip install -r requirements/requirements_build.txt
- name: Build API
run: |
Expand Down
5 changes: 5 additions & 0 deletions protos/requirements/requirements_build.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
grpcio>=1.44.0,<1.48.0
grpcio-tools>=1.44.0,<1.48.0
protobuf>=3.20,<4
wheel

2 changes: 1 addition & 1 deletion protos/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from setuptools import setup
from setuptools.command.develop import develop

install_requires = ["grpcio==1.44.0", "grpcio-tools==1.44.0", "protobuf>=3.20,<4"]
install_requires = ["grpcio>=1.44.0,<1.48.0", "grpcio-tools>=1.44.0,<1.48.0", "protobuf>=3.20,<4"]

# Get the long description from the README file
HERE = os.path.abspath(os.path.dirname(__file__))
Expand Down

0 comments on commit bbeee71

Please sign in to comment.