Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logging default value to be error #77

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

margalva
Copy link
Collaborator

Change logging default value to match the one used by pyensight, so that scripts that use both pydynamicreporting and pyensight do not run into unexpected outputs as the logging level is overwritten.

@margalva margalva requested a review from randallfrank October 25, 2023 20:46
@margalva margalva enabled auto-merge (squash) October 30, 2023 17:51
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #77 (d70d22d) into main (1ebebe3) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   75.79%   75.79%           
=======================================
  Files          16       16           
  Lines        4937     4937           
  Branches     1046     1046           
=======================================
  Hits         3742     3742           
  Misses        845      845           
  Partials      350      350           
Files Coverage Δ
src/ansys/dynamicreporting/core/adr_service.py 80.29% <50.00%> (ø)

@margalva margalva merged commit 1398b51 into main Oct 30, 2023
21 checks passed
@margalva margalva deleted the fix/logging_level branch October 30, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants