-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/yuanrui/json #213
base: main
Are you sure you want to change the base?
Feat/yuanrui/json #213
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 83.40% 83.55% +0.15%
==========================================
Files 17 17
Lines 5315 5364 +49
==========================================
+ Hits 4433 4482 +49
Misses 882 882 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Thank you.
…d hardcode by adding a genertor layer
…JSON keys; 2. For other keys, if not given in the JSON file, loading with the default values; 3. Move outside-class methods into the class as private methods
Error checking newly added in this PR includes:
Error handling and feedback:
Once the error happens, a prompt will pop up providing the detailed information to help the user understand what happens and debug.
Known but not done yet in this PR:
Check 'sort_selection' and 'params' - lack of necessary requirements
Edit:
Added 2 new features per comments and requests: