-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StaticMechanicalSimulation.thermal_strain #483
Conversation
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 83.49% 83.27% -0.23%
==========================================
Files 45 45
Lines 4973 5009 +36
==========================================
+ Hits 4152 4171 +19
- Misses 821 838 +17 |
return self._get_result( | ||
base_name="ETH", | ||
location=location, | ||
category=ResultCategory.matrix, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PProfizi do we make any difference between symmetrical matrix and matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbellot000 we do not, no, not yet
@@ -4148,6 +4148,873 @@ def creep_strain_equivalent_elemental( | |||
skin=skin, | |||
) | |||
|
|||
def thermal_strain( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is thermal strain available in harmonic, modal and/or transient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbellot000 I do not see why it would not. I'll implement those too. I wanted to treat the issue quickly so I made this PR for Static, but I can definitely change its scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbellot000 I checked and Mechanical does not propose thermal strain results for modal or harmonic analyses so I'd rather not expose that unless someone specifically asks or if you are aware that this is a use-case.
PS: added it for transient though
Closes #481