Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StaticMechanicalSimulation.thermal_strain #483

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Sep 8, 2023

Closes #481

@PProfizi PProfizi added the enhancement New feature or request label Sep 8, 2023
@PProfizi PProfizi self-assigned this Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #483 (ddd98b2) into master (90c1619) will decrease coverage by 0.23%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
- Coverage   83.49%   83.27%   -0.23%     
==========================================
  Files          45       45              
  Lines        4973     5009      +36     
==========================================
+ Hits         4152     4171      +19     
- Misses        821      838      +17     

return self._get_result(
base_name="ETH",
location=location,
category=ResultCategory.matrix,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi do we make any difference between symmetrical matrix and matrix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbellot000 we do not, no, not yet

@@ -4148,6 +4148,873 @@ def creep_strain_equivalent_elemental(
skin=skin,
)

def thermal_strain(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is thermal strain available in harmonic, modal and/or transient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbellot000 I do not see why it would not. I'll implement those too. I wanted to treat the issue quickly so I made this PR for Static, but I can definitely change its scope.

Copy link
Contributor Author

@PProfizi PProfizi Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbellot000 I checked and Mechanical does not propose thermal strain results for modal or harmonic analyses so I'd rather not expose that unless someone specifically asks or if you are aware that this is a use-case.
PS: added it for transient though

@PProfizi PProfizi merged commit 9af0c05 into master Sep 11, 2023
@PProfizi PProfizi deleted the feat/thermal_strains branch September 11, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thermal strain quantities (EPTH) not exposed via direct API in PyDPF-Post
2 participants