Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples/refactor custom plugin examples #1946

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Nov 29, 2024

Refactor examples on custom Python operators and plugins by creating helpers to download files.
This prepares their revamping into tutorials and hides the file retrieval logic from the user, which is something we do not need to show for the examples.

@PProfizi PProfizi added the examples Related to PyDPF-Core examples label Nov 29, 2024
@PProfizi PProfizi self-assigned this Nov 29, 2024
Base automatically changed from fix/examples_custom_operator_downloads to master November 29, 2024 12:36
@PProfizi PProfizi force-pushed the examples/refactor_custom_plugin_examples branch from 90dae29 to 3d46569 Compare November 29, 2024 12:37
@PProfizi PProfizi requested a review from ansjhajjar November 29, 2024 12:47
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (effc7f8) to head (324a006).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1946      +/-   ##
==========================================
+ Coverage   88.03%   88.06%   +0.02%     
==========================================
  Files          83       83              
  Lines        9973     9993      +20     
==========================================
+ Hits         8780     8800      +20     
  Misses       1193     1193              

@PProfizi PProfizi merged commit bc43b4d into master Nov 29, 2024
45 checks passed
@PProfizi PProfizi deleted the examples/refactor_custom_plugin_examples branch November 29, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Related to PyDPF-Core examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants