Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add WorkflowTopology class and workflow_to_workflow_topology operator #1902
feat: add WorkflowTopology class and workflow_to_workflow_topology operator #1902
Changes from all commits
feded14
4ff8c4e
f8467b6
2078cd0
46c79f8
9880d99
87aacb8
4dfcee5
2bc8fcd
0e59baf
09abcd7
5962788
f9ff71e
529909b
0d8d7fc
2ba8475
da60366
0b7522d
71f35ae
6052034
5a026b3
c047105
9e28ee6
1399247
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 54 in src/ansys/dpf/core/custom_container_base.py
Codecov / codecov/patch
src/ansys/dpf/core/custom_container_base.py#L54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Matteo-Baussart-ANSYS can a Workflow also potentially take in or output a WorkflowTopology object?
Can an operator take a WorkflowTopology as input?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WorkflowTopology can be the output for an Operator and from a Workflow. Following syntaxes are tested:
As for inputs, there is currently no operator requiring a
CustomContainerBase
as input.Check warning on line 79 in src/ansys/dpf/core/helpers/utils.py
Codecov / codecov/patch
src/ansys/dpf/core/helpers/utils.py#L78-L79
Check warning on line 82 in src/ansys/dpf/core/helpers/utils.py
Codecov / codecov/patch
src/ansys/dpf/core/helpers/utils.py#L81-L82
Check warning on line 85 in src/ansys/dpf/core/helpers/utils.py
Codecov / codecov/patch
src/ansys/dpf/core/helpers/utils.py#L84-L85
Check warning on line 90 in src/ansys/dpf/core/helpers/utils.py
Codecov / codecov/patch
src/ansys/dpf/core/helpers/utils.py#L90
Check warning on line 94 in src/ansys/dpf/core/outputs.py
Codecov / codecov/patch
src/ansys/dpf/core/outputs.py#L94
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Matteo-Baussart-ANSYS same, missing a docstring and typehinting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added docstring and typehinting
Check warning on line 978 in src/ansys/dpf/core/workflow.py
Codecov / codecov/patch
src/ansys/dpf/core/workflow.py#L978
Check warning on line 982 in src/ansys/dpf/core/workflow.py
Codecov / codecov/patch
src/ansys/dpf/core/workflow.py#L981-L982
Check warning on line 984 in src/ansys/dpf/core/workflow.py
Codecov / codecov/patch
src/ansys/dpf/core/workflow.py#L984