Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update_operators.yml to allow automatic sync #1312

Merged
merged 11 commits into from
Dec 8, 2023
Merged

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Dec 8, 2023

This PR enacts changes on update_operators.yml to be called directly be the dpf_standalone PRs which will wait for the checks results.
This way the dpf-standalone PR actually properly tests updated client code based on the server modifications proposed in the dpf_standalone Windows PR.
Also, use of a PAT enables for automatic run of the checks upon PR creation, unlike the previous version.

@PProfizi PProfizi self-assigned this Dec 8, 2023
@PProfizi PProfizi added the CI/CD Related to CI/CD label Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #1312 (730deae) into master (6f8e75a) will decrease coverage by 1.25%.
The diff coverage is n/a.

❗ Current head 730deae differs from pull request most recent head 048a686. Consider uploading reports for the commit 048a686 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1312      +/-   ##
==========================================
- Coverage   87.52%   86.28%   -1.25%     
==========================================
  Files          81       81              
  Lines        9243     9236       -7     
==========================================
- Hits         8090     7969     -121     
- Misses       1153     1267     +114     

@PProfizi PProfizi requested a review from cbellot000 December 8, 2023 13:27
.github/workflows/update_operators.yml Show resolved Hide resolved
.github/workflows/update_operators.yml Outdated Show resolved Hide resolved
@@ -126,7 +139,13 @@ jobs:
title: Update generated code for DPF ${{ github.event.inputs.ANSYS_VERSION || '242' }}${{ github.event.inputs.standalone_branch_suffix || '' }} on ${{ github.ref_name }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hardcoding '242', you can as well dynamically load a file at the beginning of the pipeline and assign a variable to hold the current value of the version. Thus you could have only one source of truth. But it's details.

Copy link
Contributor Author

@PProfizi PProfizi Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'll eventually do is propagate from TFS the number of the last PR merged in DPF. I'll name the dpf-standalone PR and branch with this, and give it as input to this workflow to also name the PyDPF-Core PR and branch. That way instead of relying on something generic, we'll be able to know exactly which version of the server code we are synchronizing for. (That's the best way to know since we do not increment the server's version with a devX suffix)

@PProfizi PProfizi merged commit 9cfd83b into master Dec 8, 2023
33 of 35 checks passed
@PProfizi PProfizi deleted the ci/distinct_id branch December 8, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants