-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: command issues #374
base: main
Are you sure you want to change the base?
fix: command issues #374
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 84.37% 84.03% -0.34%
==========================================
Files 13 13
Lines 2432 2481 +49
==========================================
+ Hits 2052 2085 +33
- Misses 380 396 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
As discussed with @RobPasMue, a link has been added to redirect the user to the correct documentation webpage for additional or missing arguments. I decided not to add the |
This PR fixes the following main issues:
First issue
The first one was discovered in ansys/pymapdl#3385 (comment).
It was mainly involving empty argument handling as the following commands are not identical in MAPDL due to an additional coma in the first command:
Second issue
Digging into the code, I also discovered some commands needed specific treatment. This is the case for
SECMODIF
for instance.PyMAPDL current documentation:
MAPDL documentation:
Incorrect MAPDL-CMD-CONV documentation:
The current proposition is the following:
An
addional_command_arg
has been added to the python argument that enable the user to pass whatever needed additional arguments (which vary depending onkywrd
value).