Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: general structure #356

Merged
merged 25 commits into from
Dec 4, 2024
Merged

maint: general structure #356

merged 25 commits into from
Dec 4, 2024

Conversation

clatapie
Copy link
Collaborator

@clatapie clatapie commented Oct 24, 2024

This PR updates the general structure of ast_tree.py and fixes a issues related to the CustomFunctions class.

Some adjustments were needed due to the fact arguments can be different between the custom functions and the autogenerated one. In this case, the arguments within the custom functions are the ones used.

@clatapie clatapie self-assigned this Oct 24, 2024
@github-actions github-actions bot added the maintenance Package and maintenance related label Oct 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 79.43262% with 29 lines in your changes missing coverage. Please review.

Project coverage is 84.37%. Comparing base (d6b48b2) to head (a5b3ffa).

Files with missing lines Patch % Lines
src/pyconverter/xml2py/formatter.py 10.00% 9 Missing ⚠️
src/pyconverter/xml2py/custom_functions.py 86.44% 8 Missing ⚠️
src/pyconverter/xml2py/writer.py 70.83% 7 Missing ⚠️
src/pyconverter/xml2py/cli.py 25.00% 3 Missing ⚠️
src/pyconverter/xml2py/ast_tree.py 95.45% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   84.55%   84.37%   -0.18%     
==========================================
  Files          13       13              
  Lines        2337     2432      +95     
==========================================
+ Hits         1976     2052      +76     
- Misses        361      380      +19     
Flag Coverage Δ
coverage 84.37% <79.43%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clatapie clatapie mentioned this pull request Nov 28, 2024
10 tasks
@clatapie clatapie requested a review from RobPasMue December 4, 2024 13:38
@clatapie clatapie marked this pull request as ready for review December 4, 2024 13:38
@clatapie clatapie enabled auto-merge (squash) December 4, 2024 13:42
@clatapie clatapie merged commit 012b7a3 into main Dec 4, 2024
20 checks passed
@clatapie clatapie deleted the maint/general_structure branch December 4, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants