Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed linting issues causing GitHub action failures #180

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Fixed linting issues causing GitHub action failures #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9285395
Fixed linting issues causing GitHub action failures
jce-redhat Aug 29, 2024
a2274de
resized image to convert to RGBA
jce-redhat Aug 29, 2024
2f0a2cf
trying a new file with a new name
jce-redhat Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed .github/images/setup_domain_end_state.png
View file
Open in desktop
Binary file not shown.
Binary file added .github/images/setup_domain_final_state.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion windows/connect.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
timeout: "{{ wait_for_timeout_sec | default(300) }}"

- name: Ping the windows host
ansible.builtin.win_ping:
ansible.windows.win_ping:
1 change: 1 addition & 0 deletions windows/create_ad_domain.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
dns_domain_name: ansible.local
safe_mode_password: "{{ lookup('community.general.random_string', min_lower=1, min_upper=1, min_special=1, min_numeric=1) }}"

- name: Verify domain services running

Check failure on line 26 in windows/create_ad_domain.yml

View workflow job for this annotation

GitHub Actions / pre-commit

no-handler 

Tasks that run when changed should likely be handlers.
# noqa no-handler
when: r_create_domain is changed
ansible.builtin.include_tasks:
file: tasks/domain_services_check.yml
Expand Down
2 changes: 1 addition & 1 deletion windows/setup_domain_workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ There are additional groups created in the **Demo Inventory** for interacting wi

In the validation step, you can expect to see the following output based on querying AD computers:

![Expected Output](../.github/images/setup_domain_end_state.png)
![Expected Output](../.github/images/setup_domain_final_state.png)
Loading