fix network report linting

ansible · Oct 9, 2023 · 615a6dd · 615a6dd
1 parent 1a002e5
commit 615a6dd
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 10 deletions.
diff --git a/collections/ansible_collections/demo/patching/roles/build_report_network/tasks/main.yml b/collections/ansible_collections/demo/patching/roles/build_report_network/tasks/main.yml
@@ -1,29 +1,29 @@
 ---
 - name: Create web directory if it does not exist
   ansible.builtin.file:
-    path: "{{ file_path }}"
+    path: "{{ build_report_network_file_path }}"
     state: directory
     mode: "0755"
 
 - name: Create HTML report
   ansible.builtin.template:
     src: report.j2
-    dest: "{{ file_path }}/network.html"
+    dest: "{{ build_report_network_file_path }}/network.html"
     mode: "0644"
   check_mode: false
 
 - name: Copy CSS over
   ansible.builtin.copy:
     src: "css"
-    dest: "{{ file_path }}"
+    dest: "{{ build_report_network_file_path }}"
     directory_mode: true
     mode: "0775"
   check_mode: false
 
 - name: Copy logos over
   ansible.builtin.copy:
     src: "{{ item }}"
-    dest: "{{ file_path }}"
+    dest: "{{ build_report_network_file_path }}"
     directory_mode: true
     mode: "0644"
   loop:

diff --git a/...ections/ansible_collections/demo/patching/roles/build_report_network/templates/ansible.j2 b/...ections/ansible_collections/demo/patching/roles/build_report_network/templates/ansible.j2
@@ -11,7 +11,7 @@
   </tr>
   <tr>
     <td>Transport</td>
-    <td class="sub_net_info">{% set ansible_connection = hostvars[network_switch]['ansible_net_api'] %}{{ transport[ansible_connection] }}</td>
+    <td class="sub_net_info">{% set ansible_connection = hostvars[network_switch]['ansible_net_api'] %}{{ build_report_network_transport[ansible_connection] }}</td>
   </tr>
   <tr>
     <td>Ansible Mgmt IP</td>

diff --git a/collections/ansible_collections/demo/patching/roles/build_report_network/templates/report.j2 b/collections/ansible_collections/demo/patching/roles/build_report_network/templates/report.j2
@@ -45,7 +45,7 @@ collapsible: true
               <tbody>
                 <tr>
                   <td>Platform</td>
-                  <td class="sub_net_info">{% set ansible_network_os = hostvars[network_switch]['ansible_net_system'] %}{{ vendor[ansible_network_os]}} {{hostvars[network_switch]['ansible_net_system'] }}</td>
+                  <td class="sub_net_info">{% set ansible_network_os = hostvars[network_switch]['ansible_net_system'] %}{{ build_report_network_vendor[ansible_network_os]}} {{hostvars[network_switch]['ansible_net_system'] }}</td>
                 </tr>
                 <tr>
                   <td>Code Version</td>

diff --git a/collections/ansible_collections/demo/patching/roles/build_report_network/vars/main.yml b/collections/ansible_collections/demo/patching/roles/build_report_network/vars/main.yml
@@ -1,12 +1,12 @@
 ---
-file_path: "{{ web_path | default('/var/www/html/reports') }}"
-vendor:
+build_report_network_file_path: "{{ web_path | default('/var/www/html/reports') }}"
+build_report_network_vendor:
   ios: &my_value 'Cisco'
   nxos: *my_value
   iosxr: *my_value
   junos: "Juniper"
   eos: "Arista"
-transport:
+build_report_network_transport:
   cliconf: "Network_CLI"
   netconf: "NETCONF"
   nxapi: "NX-API"
diff --git a/windows/powershell_dsc.yml b/windows/powershell_dsc.yml
@@ -7,7 +7,6 @@
     - name: Make Nuget Package Provider exist
       ansible.windows.win_powershell:
         script: "{{ lookup('file', 'Install-NuGet.ps1') }}"
-      check_mode: false
 
     - name: Setup the SecurityPolicyDSC module
       community.windows.win_psmodule: