Check if param flag values are defined, not truthiness

[zjleblanc]

Addresses #365 by checking if module parameters which represent flags are defined, preventing evaluation of their truthyness. Current behavior will ignore an incoming value of false and default back to true because of the conditional logic:

Example:
module.params["enabled"] = False
if module.params.get("enabled") evaluates to False, but the intent is to determine if it has been defined, so we want this to evaluate to True.

This PR addresses the same issue for swap_single_source param.

[Alex-Izquierdo]

Thanks @zjleblanc
Actually all the parameters of the module are affected by this issue and probably the rest of modules, so I will prefer to create a PR to fix all of them.

[zjleblanc]

@Alex-Izquierdo sounds like a plan. Would you like me to close this PR for now? Or start looking at other params and start adding to it?

[Alex-Izquierdo]

Hi @zjleblanc
Sorry for the late response, I was on holidays.
I've checking it deeply and your PR already addresses all the issues, we don't need more changes. The only thing is that we should test this specific issue. Would you mind to add a new task in https://github.com/ansible/event-driven-ansible/blob/main/tests/integration/targets/activation/tasks/main.yml so we can verify that enabled param is correctly created?

Otherwise I can recreate the PR with the test.

Thank you very much.

[zjleblanc]

@Alex-Izquierdo added an assert based on the existing integration tasks - will check back to make sure it passes.

[Alex-Izquierdo]

We don't need this assertion, it is a feature of the collection for configuring event streams. not a field in the backend, rest LGTM