Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure mandatory params for activation #352

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

Alex-Izquierdo
Copy link
Contributor

@Alex-Izquierdo Alex-Izquierdo commented Nov 15, 2024

Decision Environment, organization, project and rulebook are mandatory for the activation. If the lookup of these resources fail or don't exist, the module sends a request that fails and returns a confusing error to the user like:

TASK [Activate a rulebook] *****************************************************
2024-11-07T12:43:17Z ifxry5zyniyz INFO: setup-control: fatal: [localhost]: FAILED! => {"changed": false, "msg": "Failed to create/update rulebook activation: HTTP error

{'rulebook_id': ['This field is required.']}
"}

Ensure these params and handle properly their absence.

Jira: https://issues.redhat.com/browse/AAP-35360

@Alex-Izquierdo Alex-Izquierdo merged commit 2cd670a into ansible:main Nov 18, 2024
17 checks passed
@Alex-Izquierdo Alex-Izquierdo deleted the enforce-activation-params branch November 18, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants