fix: remove event_stream_type for event_stream module #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Izquierdo
force-pushed
the
remove-event-stream-type
branch
from
bff757e to
bcdc66d
Compare
Alex-Izquierdo
force-pushed
the
remove-event-stream-type
branch
from
bcdc66d to
2b69e9f
Compare
Alex-Izquierdo
force-pushed
the
remove-event-stream-type
branch
from
2b69e9f to
982ca0d
Compare
Alex-Izquierdo
force-pushed
the
remove-event-stream-type
branch
from
982ca0d to
971b3ea
Compare
Alex-Izquierdo
force-pushed
the
remove-event-stream-type
branch
from
971b3ea to
b8fc440
Compare
Alex-Izquierdo
force-pushed
the
remove-event-stream-type
branch
from
b8fc440 to
c47856a
Compare
Signed-off-by: Alex <[email protected]>
Alex-Izquierdo
force-pushed
the
remove-event-stream-type
branch
from
c47856a to
14e1178
Compare
alinabuzachis
approved these changes
Oct 10, 2024
Alex-Izquierdo
temporarily deployed
to
release
GitHub Actions
Inactive
mkanoor
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event_stream_type is not necessary to create the event stream and it is misleading since the user has no way to know what is the value for it and it will end up in unexpected errors if its sent to the api. The type is already set by the backend based on the credential chosen. The API will remove it as well, its existence is an error and it only exists in the UI in order to filter existing credentials by type.
Jira: https://issues.redhat.com/browse/AAP-33196