event_stream - Ensure forward_events works as expected #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinabuzachis
changed the title
alinabuzachis
force-pushed
the
event_stream_fix
branch
from
355145f to
3f64ad6
Compare
|
@Alex-Izquierdo is there any label for deprecated features? |
There was a problem hiding this comment.
Hi @alinabuzachis , the option name is correct, because "forward events" is what we have right now in the UI. This is a similar case that we had with source mappings, the UI has a different interface than the API, so we decided the module to align with the UI.
In this way, we don't need to rename or add new fields, just we have to reverse the boolean for the test_mode api param.
test_mode = not forward_events
alinabuzachis
changed the title
alinabuzachis
force-pushed
the
event_stream_fix
branch
from
75f0148 to
ff3688d
Compare
|
Will rebase once #336 is merged. |
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
event_stream_fix
branch
from
94bd92b to
f03f388
Compare
Alex-Izquierdo
approved these changes
Oct 9, 2024
zkayyali812
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event_stream - Ensure forward_events works as expected