Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some critical types to module_utils and fix logic #270

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Aug 17, 2024

This change adds minimal types and uncovers several logic bugs, where users of controller.get_one_or_many assumed it will not return a list.

I had to replace some calls of get_one_or_many with get_exactly_one, so please double check them.

Depends-On: #271

This change adds minimal types and uncovers several logic bugs, where
users of controller.get_one_or_many assumed it will not return a list.
@Akasurde Akasurde merged commit a92be59 into main Aug 19, 2024
13 of 14 checks passed
@Akasurde Akasurde deleted the chore/mypy branch August 19, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants