Add schemas for our source plugins #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How will be read this by the UI? |
Alex-Izquierdo
previously approved these changes
Feb 20, 2024
|
It could be good to have a CI check to validate the schema. |
This is some of the work needed for the UI to generate source args for Fanout.
Alex-Izquierdo
previously approved these changes
Feb 20, 2024
msmagnanijr
previously approved these changes
May 20, 2024
|
ssbarnea
changed the title
ssbarnea
dismissed stale reviews from Alex-Izquierdo and msmagnanijr
via
0f9492e
|
I will be merging this, note that @msmagnanijr and @Alex-Izquierdo already gave +1 but when I rebased it, the reviews were lost. |
ssbarnea
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some of the work needed for the UI to generate source args for Fanout.