-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add raise_error and log_error option to insert_hosts_to_meta filter #197
Conversation
896d3dc
to
8fe04ae
Compare
656a019
to
5bfb11c
Compare
ac59ba3
to
2dc84e1
Compare
@bzwei should we add documentation here too https://ansible.readthedocs.io/projects/rulebook/en/latest/filters.html |
2dc84e1
to
62c2d15
Compare
Yes. |
I'm concerned about mixing scopes of the documentation. Why not create a |
@bzwei
Nothing changes, there is no log messages and there is no exception. A customer has to be told to use the new raise_exceptions option to see anything meaningful. We are back to square one. This PR doesn't help the customer self diagnose the issue. They might go back to using the limit approach. We need to log.error by default so out of the box we see an error in the Activation log that the customer can be told to turn off by modifying the rulebook which is an easier change for them. Maybe log_errors: True|False. True by default. If they feel there is too much noise they could just set the log_errors: False |
42204ff
to
5381251
Compare
Hi @bzwei Ruff is failing with:
CI criteria for eda collections is a pending discussion. In the case of PLR0913 you already have a exception but I think it must be in line #52. Anyway, since filters receives the plain args and generally speaking, I think it is perfectly reasonable to add the exception for PLR0913 in general in https://github.com/ansible/event-driven-ansible/blob/main/tox.ini#L18 In the case of TRY400 I think we want to keep the check but this case justifies a line exception. |
5381251
to
264aca0
Compare
264aca0
to
45cebdf
Compare
45cebdf
to
6f33f4e
Compare
https://issues.redhat.com/browse/AAP-17232