Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAP-11261] Add MQTT event source #113

Closed
wants to merge 25 commits into from
Closed

Conversation

kubealex
Copy link

Adding an MQTT event source for rulebooks - Tested

@kubealex
Copy link
Author

kubealex commented Jul 3, 2023

hi team, any news on this one?

@kurokobo
Copy link

kurokobo commented Aug 12, 2023

@kubealex
Hi, thanks for introducing this plugin!
I have created small PR with following changes for your branch to make it work with the latest collection: kubealex#1

  • Merge latest main branch
  • Move mqtt.py from extensions/eda/plugins/event_sources to extensions/eda/plugins/event_source where other plugins are placed
  • Remove dict from import to avoid the error ImportError: cannot import name 'dict' from 'typing'
  • Add aiomqtt to requirements.txt to make Ansible Builder installable required modules for this plugin

@kubealex
Copy link
Author

Thank you @kurokobo! I just merged your contribution into the branch 🚀

React to decommissioning of asyncio_mqtt
@jpmens
Copy link

jpmens commented Sep 10, 2023

I am very much looking forward to seeing this merged. :)

@tonyskapunk
Copy link

I've been using this patch locally and has been working as expected, thanks!!

@Alex-Izquierdo
Copy link
Contributor

Alex-Izquierdo commented Sep 28, 2023

Hi @kubealex

We want to express our sincere appreciation for your effort and contribution. After careful consideration, we have concluded that this plugin doesn't align with the scope of our official collection, and unfortunately, it will not be included.

However, this does not diminish the value of your work. We believe your plugin can still be highly beneficial and encourage you to offer it through your own collection. You are welcome to upload it to galaxy with the "eda" tag.

As a fellow Red Hatter, we also suggest reaching out to your product management team to explore if such a collection could be supported within Red Hat as a maintained collection.

Thank you for your understanding and contribution.

@kubealex
Copy link
Author

Thank you for the feedback Alex, much appreciated!

@jpmens @tonyskapunk and anyone who could be interested in using or including it, no worries, I'll leave it here [1] the link to the custom collection that includes the plugin.

[1] https://galaxy.ansible.com/kubealex/eda

@kurokobo
Copy link

kurokobo commented Sep 29, 2023

@Alex-Izquierdo
Hi, thanks for working on this.
Do you have any plan to update the documentation for Ansible Rulebook?

In the documentation, the mqtt plugin is mentioned as example of Event Bus Plugins.

  1. Event Bus Plugins
    These are plugins that listen to a stream of events from a source where the connection is established by the plugin itself.
    Examples of this are the kafka and mqtt plugins.

https://ansible.readthedocs.io/projects/rulebook/en/stable/sources.html

This is why I reached out here to find the status of MQTT plugin. This documentation might cause users misunderstanding that an officially maintained MQTT plugin exists (yes, I am one of the users who misunderstood).

It would be great if the MQTT plugin is officially implemented as the documentation shows, but since as you stated this plugin no longer merged into this collection, the documentation should be updated.

Please let me know if I should create an issue in ansible-rulebook or create a PR to remove MQTT from the documentation. Thanks in advance!

@Alex-Izquierdo
Copy link
Contributor

Thanks for raising this issue @kurokobo
It will be fixed on ansible/ansible-rulebook#590

@kurokobo
Copy link

Thanks for rapid update😃

@jpmens
Copy link

jpmens commented Oct 1, 2023

@kubealex thanks for the link to the custom collection that includes the plugin (https://galaxy.ansible.com/kubealex/eda), but that is 404 which, I assume, is because of the transition from Galaxy to -NG.

The current link is https://galaxy.ansible.com/ui/repo/published/kubealex/eda/ but I think it's probably safer to mention the link to your repository at https://github.com/kubealex/kubealex.eda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants