-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: combine event streams with activations #657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkanoor
reviewed
Feb 7, 2024
hsong-rh
force-pushed
the
enable_fanout
branch
from
February 7, 2024 23:38
cf2532a
to
a3412c8
Compare
mkanoor
reviewed
Feb 7, 2024
mkanoor
changed the title
Combine event streams with activations
feat: combine event streams with activations
Feb 7, 2024
mkanoor
reviewed
Feb 8, 2024
mkanoor
reviewed
Feb 8, 2024
mkanoor
reviewed
Feb 8, 2024
mkanoor
reviewed
Feb 8, 2024
hsong-rh
force-pushed
the
enable_fanout
branch
4 times, most recently
from
February 8, 2024 17:20
e0e1705
to
fd00c1f
Compare
hsong-rh
force-pushed
the
enable_fanout
branch
2 times, most recently
from
February 8, 2024 18:18
daa3878
to
1dbc719
Compare
UI PR ansible/ansible-ui#1571 |
hsong-rh
force-pushed
the
enable_fanout
branch
from
February 8, 2024 20:02
1dbc719
to
4f30ae0
Compare
hsong-rh
force-pushed
the
enable_fanout
branch
from
February 9, 2024 15:41
4f30ae0
to
57ebc78
Compare
hsong-rh
force-pushed
the
enable_fanout
branch
from
February 9, 2024 16:24
57ebc78
to
ea7d435
Compare
hsong-rh
force-pushed
the
enable_fanout
branch
from
February 9, 2024 16:33
ea7d435
to
0eb7a5c
Compare
mkanoor
approved these changes
Feb 9, 2024
bzwei
approved these changes
Feb 12, 2024
The code LGTM. Haven't got chance to test it. I am ok to have it merged. Will try it soon. |
Tested and worked fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAP-20144
https://issues.redhat.com/browse/AAP-20036
https://issues.redhat.com/browse/AAP-19799
This is the first attempt at getting a basic fanout working with the latest model changes. We can create event streams attach them to activations, report on the events for each one separately, get the logs for each one separately. With the basic stuff working with complete UI support we should be able to continue parallel work in QE and Dev to harden some of the internal plumbing needed to get fanout to closure. There are unit tests for most of the changes. We would start writing the first E2E tests once we get a client generated from this.
Testing this PR
To start up the test environment we need the 2 images
You can build the image from this PR or use the ones below
On Linux if using amd chip use
Start up the server using docker_compose or minikube
Log into the EDA Server
Steps