Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable relationship with parents in rulebook process #654

Merged
merged 1 commit into from
Feb 7, 2024
Merged

feat: enable relationship with parents in rulebook process #654

merged 1 commit into from
Feb 7, 2024

Conversation

Alex-Izquierdo
Copy link
Collaborator

  • Two optional foreign keys for event_streams and activations
  • A type field populated from the parent defined in an enum
  • get_parent function
  • model validation to ensure the parent and type
  • Update tests accordingly
    Jira: https://issues.redhat.com/browse/AAP-20503

@Alex-Izquierdo Alex-Izquierdo requested a review from a team as a code owner February 7, 2024 15:19
@Alex-Izquierdo Alex-Izquierdo force-pushed the relationship-rulebook-process branch from 54d3600 to 21cef5d Compare February 7, 2024 15:21
@Alex-Izquierdo Alex-Izquierdo force-pushed the relationship-rulebook-process branch from 21cef5d to 41d185e Compare February 7, 2024 15:23
@mkanoor
Copy link
Contributor

mkanoor commented Feb 7, 2024

@Alex-Izquierdo do we need a migration to set the parent_type in existing rows in the DB and set it to Activation

@Alex-Izquierdo
Copy link
Collaborator Author

Look carefully at the changes in the RulebookProcess model, since I moved it to a new file, you miss the diff.

@Alex-Izquierdo Alex-Izquierdo merged commit 88aca57 into ansible:main Feb 7, 2024
2 checks passed
@Alex-Izquierdo Alex-Izquierdo deleted the relationship-rulebook-process branch February 7, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor mkanoor approved these changes

@hsong-rh hsong-rh hsong-rh approved these changes

@bzwei bzwei bzwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alex-Izquierdo @mkanoor @bzwei @hsong-rh