-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAP-18826] Integrate Resources API #652
Conversation
7549ec2
to
af227f8
Compare
Don't we need to bump DAB? |
I initially thought we needed since there was recent migration changes regarding resource_registry lib in dab, but while testing this PR locally I didn't encounter any issues. I will bump it just to be safe. |
dc5a5f0
to
292c8fb
Compare
@Dostonbek1 in your local env you were working with the pinned version?
|
The fact that the tests are green makes me wonder if we need a better test coverage in the integration with DAB |
Yeah this is related with the migrations in resource_registry app, there is a fix for it in DAB but it is after the version that we are using right now. So bumping the DAB version should resolve it. |
b13ef9b
to
b4148b7
Compare
b4148b7
to
dc4b469
Compare
* implement resource_registry app from django-ansible-base
JIRA: AAP-18826