-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to update activations via the patch API #1174
base: feature/edit-activation
Are you sure you want to change the base?
Conversation
a20f967
to
6a441e4
Compare
e2e test failure is fixed by https://github.com/ansible/eda-qa/pull/447 |
@bzwei Since we might be updating and restarting an Activation should we log a line here to indicate that the Activation has been updated, since if the user picks up different rulebook during an update the old Rule Audit wont make any sense. Having a log line that indicates that the Activaiton has been updated since creation will give some context to the old Rule Audits. The old Rule Audits point to an Activation Instance log and this message will tell us that the user has updated this Activation.
|
Activations must be in disabled mode. Most fields are editable. AAP-37295: Edit an existing activation
Quality Gate failedFailed conditions |
@mkanoor Here I have the log https://github.com/ansible/eda-server/pull/1174/files#diff-3aa1d8dc47ee0af34b544249cc19758b5919dbddf7057e84dc032f49f6235f33R176. Is it sufficient? |
@bzwei That is an audit log that doesn't come out to the activation_instance log. That audit log was added by @zkayyali812 for audit trail. We need a one liner in the rulebook process log that is visible in the UI that shows it is an updated Activation. When you look at the the "Rule Audit" in out UI and click on the Activation it opens up our Rulebook process log thats where we would like to see it has been updated. |
We do not know whether the activation has been updated unless we introduce a new field to its model. This new line in the rulebook process log will be printed in every restart. |
Activations must be in disabled mode. Most fields are editable.
AAP-37295: Edit an existing activation