-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick up help_text changes from DAB #1154
Conversation
Ok, so it seems we need to actually update DAB to hit this. Right now I have ansible/django-ansible-base#657 open so we can potentially do this with a tag. I can try to do it with the current pyproject.toml, but I don't think it'll work. |
I hacked the poetry.lock file by doing it manually, intending to reference the commit ansible/django-ansible-base@20f43da |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
58292bd
to
b61e540
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased the PR to pull in latest changes, apologies for messing up any commit history here.
The PR ansible/django-ansible-base#638 modified
help_text
on fields of the common models, and eda-server was using those abstract classes as bases for some of their models.This causes checks to fail on other PRs, so I expect this needs to get in.