Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up help_text changes from DAB #1154

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

AlanCoding
Copy link
Member

The PR ansible/django-ansible-base#638 modified help_text on fields of the common models, and eda-server was using those abstract classes as bases for some of their models.

This causes checks to fail on other PRs, so I expect this needs to get in.

@AlanCoding AlanCoding requested a review from a team as a code owner November 26, 2024 20:14
@AlanCoding
Copy link
Member Author

Ok, so it seems we need to actually update DAB to hit this. Right now I have ansible/django-ansible-base#657 open so we can potentially do this with a tag. I can try to do it with the current pyproject.toml, but I don't think it'll work.

@AlanCoding
Copy link
Member Author

I hacked the poetry.lock file by doing it manually, intending to reference the commit ansible/django-ansible-base@20f43da

Copy link
Member

@Dostonbek1 Dostonbek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run this locally and confirm the help texts for name fields of organization and team models.
Organization:
image

Team:
image

Not sure how to manually check for the other fields though but I'd assume they should be there considering it works for name fields.

@Dostonbek1 Dostonbek1 requested a review from a team December 3, 2024 16:48
Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link
Collaborator

@zkayyali812 zkayyali812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased the PR to pull in latest changes, apologies for messing up any commit history here.

@Dostonbek1 Dostonbek1 merged commit 28a7b9a into ansible:main Dec 4, 2024
8 checks passed
Alex-Izquierdo pushed a commit to Alex-Izquierdo/eda-server that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants