feat: handle binary files in file injectors #1151
Merged
+114
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkanoor
changed the title
bzwei
reviewed
Nov 22, 2024
hsong-rh
reviewed
Nov 25, 2024
|
@mkanoor are you going to add pytests for function |
hsong-rh
reviewed
Nov 25, 2024
For Kerberos we need to support a keytab file which is a binary
file and its used for service accounts during authentication
with Kerberos.
This uses the format: binary_base64 in the field definition to
let the UI know that the expected file is supposed to be binary
and needs to be sent up as base64
You can create a credential with the following schema
Inputs configuration
```
fields:
- id: keytab
type: string
label: Kerberos Keytab file
format: binary_base64
secret: true
help_text: Please select a Kerberos Keytab file
multiline: true
```
Injector Configuration
```
file:
template.keytab_file: '{{ keytab }}'
```
No changes are needed to ansible-rulebook it already handles
binary files.
https://issues.redhat.com/browse/AAP-25518
|
hsong-rh
approved these changes
Nov 25, 2024
bzwei
approved these changes
Nov 25, 2024
bzwei
pushed a commit
to bzwei/eda-server
that referenced
this pull request
Dec 6, 2024
bzwei
pushed a commit
to bzwei/eda-server
that referenced
this pull request
Dec 6, 2024
bzwei
pushed a commit
to bzwei/eda-server
that referenced
this pull request
Dec 6, 2024
Alex-Izquierdo
pushed a commit
that referenced
this pull request
Dec 10, 2024
Alex-Izquierdo
pushed a commit
that referenced
this pull request
Dec 10, 2024
zkayyali812
pushed a commit
that referenced
this pull request
Dec 10, 2024
Alex-Izquierdo
pushed a commit
to Alex-Izquierdo/eda-server
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Kerberos we need to support a keytab file which is a binary file and its used for service accounts during authentication with Kerberos.
This uses the format: binary_base64 in the field definition to let the UI know that the expected file is supposed to be binary and needs to be sent up as base64
You can create a credential type with the following schema
Inputs configuration
Injector Configuration
No changes are needed to ansible-rulebook it already handles binary files.
https://issues.redhat.com/browse/AAP-25518