Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update changelog and prepare next devel version #728

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Alex-Izquierdo
Copy link
Contributor

No description provided.

@Alex-Izquierdo Alex-Izquierdo requested a review from a team December 9, 2024 19:38
zkayyali812
zkayyali812 previously approved these changes Dec 9, 2024
ttuffin
ttuffin previously approved these changes Dec 10, 2024
@zkayyali812
Copy link
Contributor

I think this test needs to be updated to pass the tests - https://github.com/ansible/ansible-rulebook/blob/main/tests/unit/test_cli.py#L11
Now that we are suffixing -dev

@Alex-Izquierdo Alex-Izquierdo dismissed stale reviews from ttuffin and zkayyali812 via 93ffa9d December 10, 2024 14:39
Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Alex-Izquierdo
Copy link
Contributor Author

I think this test needs to be updated to pass the tests - https://github.com/ansible/ansible-rulebook/blob/main/tests/unit/test_cli.py#L11 Now that we are suffixing -dev

Good catch, @zkayyali812. Test updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants