Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jUnit test reporter and upload results #707

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

zkayyali812
Copy link
Contributor

Outputs junit test results when running unit tests to an xml file.
Upload this file for integration into The Platform Readiness Dashboard

@zkayyali812 zkayyali812 force-pushed the zk/generate/jUnit-results-file branch 3 times, most recently from 6bfb3c8 to 9cbcd45 Compare August 27, 2024 19:29
@zkayyali812 zkayyali812 force-pushed the zk/generate/jUnit-results-file branch from dfbc6dc to f4c465b Compare August 27, 2024 20:36
@zkayyali812 zkayyali812 marked this pull request as ready for review August 27, 2024 20:39
@zkayyali812 zkayyali812 requested a review from a team August 27, 2024 20:40
@mkanoor
Copy link
Contributor

mkanoor commented Aug 27, 2024

@zkayyali812 What is junit? Isn't that something from the Java world?

@zkayyali812
Copy link
Contributor Author

@mkanoor it is just used as a format here to report on our testing results.

This implementation uses the same example/format documented by PDE team here - https://gitlab.cee.redhat.com/ansible/testing/ansible-component-upload-test-results/-/blob/main/.gitlab-ci.yml?ref_type=heads

Copy link
Contributor

@Alex-Izquierdo Alex-Izquierdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question:
The workflows could not be executed by forks because it requires access to those secrets a vars, Am I right? Do you want to prevent that?

@jneedle jneedle self-requested a review August 28, 2024 14:29
jneedle
jneedle previously approved these changes Aug 28, 2024
Copy link

@zkayyali812 zkayyali812 requested a review from jneedle August 28, 2024 16:13
@zkayyali812 zkayyali812 merged commit 8874c7b into main Aug 28, 2024
9 checks passed
@zkayyali812 zkayyali812 deleted the zk/generate/jUnit-results-file branch August 28, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants