fix: add generic error msg for unknown source errors #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Alex-Izquierdo It might make sense to add some tests for this with some local sources with builtin failures to see how they get reported. |
Alex-Izquierdo
force-pushed
the
source-unknown-error
branch
from
3e00a90 to
6ac9f82
Compare
|
@mkanoor added tests |
mkanoor
previously approved these changes
Jan 18, 2024
|
Solved a merge conflict |
|
@Alex-Izquierdo should we rename range_exception to a generic name since it has nothing to do with range? |
|
Hi @bzwei renamed to "source_with_exception" as we agreed. |
bzwei
previously approved these changes
Jan 29, 2024
|
Alex-Izquierdo
force-pushed
the
source-unknown-error
branch
from
0447ddd to
a4e66c0
Compare
Alex-Izquierdo
force-pushed
the
source-unknown-error
branch
from
a4e66c0 to
4739d17
Compare
hsong-rh
approved these changes
Nov 22, 2024
|
zkayyali812
approved these changes
Nov 22, 2024
|
@Alex-Izquierdo there are quality issues needed to be addressed. |
zkayyali812
pushed a commit
that referenced
this pull request
Dec 9, 2024
This is a little enhancement when the source plugin fails and raises an exception without message. Also extends the source plugin development guide. Related with https://issues.redhat.com/browse/AAP-19598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little enhancement when the source plugin fails and raises an exception without message.
Also extends the source plugin development guide.
Related with https://issues.redhat.com/browse/AAP-19598