chore: optionally allow to use a separate collection repo #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsong-rh
previously approved these changes
Nov 20, 2023
mkanoor
force-pushed
the
add_collection_repo
branch
from
45e5eb6 to
c9e9b85
Compare
When developing new features which involves using newer collection we need access to the collection in the image. When doing a developer build of an image provide a build arg for the name of repo e.g. ``` podman build --build-arg DEVEL_COLLECTION_LIBRARY=1 --build-arg DEVEL_COLLECTION_REPO=git+https://github.com/mkanoor/event-driven-ansible.git,pg_listener -t localhost/ansible-rulebook:latest . ```
mkanoor
force-pushed
the
add_collection_repo
branch
from
c9e9b85 to
c9a67fc
Compare
|
@Alex-Izquierdo Please review updated it |
Alex-Izquierdo
approved these changes
Nov 22, 2023
ttuffin
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing new features which involves using newer collection we need access to the collection in the image. When doing a developer build of an image provide a build arg for the name of repo
e.g.