chore: ruleset.name is required parameter #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every ruleset should have a name so we can post events/facts between them.
Alex-Izquierdo
approved these changes
Sep 26, 2023
ttuffin
approved these changes
Sep 27, 2023
|
I just noticed that the release notes should be updated because this is would be a breaking change. |
|
@Alex-Izquierdo It was always a required parameter, we just didn't have the schema reflecting that. ansible-rulebook/tests/test_rules.py Line 159 in f862c1a It was also one of the requirements for set_facts and post_events since they need a ruleset name to use. ansible-rulebook/tests/test_rules.py Line 171 in f862c1a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every ruleset should have a name so we can post events/facts between them.