Refactor messages into types #568
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthomasson
force-pushed
the
message_types
branch
from
9143c39 to
28908a1
Compare
|
Have you considered to use pydantic? I wonder their builtin capabilites for serialization and validation might be useful for us. |
|
Yes, pydantic is even better than dataclasses. We are already using that in eda-server for parsing the messages. It should be fine to add pydantic as a new dependency for ansible-rulebook. I'll try that too in this PR. |
benthomasson
force-pushed
the
message_types
branch
from
751f0d4 to
1e9ab26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages should have well-defined types so that senders and receivers can agree on the data that should be in the message. Refactor the messages into dataclasses.
This PR attempts to refactor the messages implemented as dicts into dataclasses.