Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zabbix_agent include_dir creation logic #1366

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

AlexPykavy
Copy link
Contributor

SUMMARY

As a string is iterable of chars, the previous logic changed the permissions for all single-character dirs: '/', 'e', 't', 'c', '/', etc.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • zabbix_agent role
ADDITIONAL INFORMATION
  • IMPORTANT: open terminal session as root because the current version of the role resets the / ownership for all users except root and zabbix group
  • run the zabbix_agent role
  • check that the ownership of the / is set to root:zabbix and the permissions are smth like drwxr-x---

As a string is iterable of chars, the previous logic changed the permissions
for all single-character dirs: '/', 'e', 't', 'c', '/', etc.
@AlexPykavy
Copy link
Contributor Author

Perhaps, it fixes #1365.

Copy link
Collaborator

@pyrodie18 pyrodie18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think this makes sense. Going to go ahead and pull it in but won't cut the release until #1361 gets updated.

@pyrodie18 pyrodie18 merged commit 6141221 into ansible-collections:main Aug 9, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants