Don't reset IPMI setting when update inventory

[masa-orca]

SUMMARY

• Don't reset IPMI setting when update inventory
• Fixes zabbix_host module: updating host inventory data causes IPMI values to be reset #1110

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

zabbix_host module

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2287d6) 79.67% compared to head (b3b0812) 79.54%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   79.67%   79.54%   -0.14%     
==========================================
  Files          34       34              
  Lines        4311     4264      -47     
  Branches     1151     1127      -24     
==========================================
- Hits         3435     3392      -43     
+ Misses        519      517       -2     
+ Partials      357      355       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BGmot]

- - zabbix_host - Don't reset IPMI setting when update inventory
+ - zabbix_host - Don't reset IPMI setting when update inventory data of a host

[masa-orca]

Thanks. I have changed to the sentence which you wrote.

[BGmot]

I don't understand why you treat let's say ipmi_privilege and ipmi_username differently? why some of them checked for being in zabbix_host_obj and some not?

[masa-orca]

Thank you for reviewing.

ipmi_privilege and ipmi_username differently?

It is no meaning. I add checks about the parameters.

why some of them checked for being in zabbix_host_obj and some not?

• We need to set the minimum parameters.
• reseting IPMI setting was coused by unnecessary parameters.
• In current source code, we cannot update value of string parameters (e.g. ipmi_username) with empty string.
  • To evaluate empty string result is false, so, the module skips adding parameter.

test_string = ""
if test_string:
    print('Update a parameter')  # This print function is never called.

[BGmot]

Thank you very much @masa-orca -)