Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EOL Ansible versions from test matrix. #1124

Closed
wants to merge 1 commit into from

Conversation

BGmot
Copy link
Collaborator

@BGmot BGmot commented Nov 13, 2023

SUMMARY

Remove EOL Ansible versions from test matrix.

ISSUE TYPE
  • Maintenance Pull Request

@BGmot BGmot requested a review from pyrodie18 November 13, 2023 03:30
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31787d1) 79.68% compared to head (d4f6d84) 77.40%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
- Coverage   79.68%   77.40%   -2.28%     
==========================================
  Files          33       33              
  Lines        4258     4258              
  Branches     1140     1140              
==========================================
- Hits         3393     3296      -97     
- Misses        513      600      +87     
- Partials      352      362      +10     

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrodie18
Copy link
Collaborator

Would argue that this is a breaking change and would need to go into 3.0.0 which is actually where I already made the change (29090f2)

@BGmot
Copy link
Collaborator Author

BGmot commented Nov 13, 2023

opps... sorry.

@BGmot BGmot closed this Nov 13, 2023
@BGmot BGmot deleted the bgmot_ansible_versions branch November 13, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants