add templategroup module to project #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
- Coverage 79.68% 79.66% -0.02%
==========================================
Files 33 34 +1
Lines 4258 4318 +60
Branches 1140 1151 +11
==========================================
+ Hits 3393 3440 +47
- Misses 513 520 +7
- Partials 352 358 +6 ☔ View full report in Codecov by Sentry. |
pyrodie18
requested changes
Oct 22, 2023
Template group API added in 6.2
pyrodie18
approved these changes
Oct 25, 2023
|
@pyrodie18 Any chance to get this one merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added a template group module that leverages the templategroup api methods (get, create, delete)
ISSUE TYPE
COMPONENT NAME
zabbix_templategroup
ADDITIONAL INFORMATION
I was looking for a way to add template groups and couldn't find one. I simply copied the zabbix_group module and tailored for template groups.