Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force become: false in zabbix-agent role api calling #1102

Conversation

miettal
Copy link
Contributor

@miettal miettal commented Oct 12, 2023

SUMMARY

in zabbix-agent role, some task require sudo. but sudo is not needed in api calling so I added became: false flag.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zabbix-agent role

ADDITIONAL INFORMATION

@pyrodie18
Copy link
Collaborator

@miettal, thank you for the PR. Is there a reason why you're explicitly making these become false? By default become is false. If you notice, in other areas we explicitly make become true when it is required.

@miettal
Copy link
Contributor Author

miettal commented Oct 13, 2023

In my env, actually, sudo was required. // Mac, ansible-core==2.14,==2.15

By default become is false.

I see. This means "became" can be controll when role calling? I'll try it.

@miettal
Copy link
Contributor Author

miettal commented Oct 13, 2023

Sorry! You are right!

I tried with became: false in role calling, it works.

I'll close this PR.

@miettal miettal closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants