Fixing issue #1066 #1098
Merged
Fixing issue #1066 #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1098 +/- ##
=======================================
Coverage 79.70% 79.70%
=======================================
Files 33 33
Lines 4247 4247
Branches 1138 1138
=======================================
Hits 3385 3385
Misses 511 511
Partials 351 351 ☔ View full report in Codecov by Sentry. |
pyrodie18
pushed a commit
that referenced
this pull request
Oct 6, 2023
|
Can someone upload this new version to galaxy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #1066 by using
self.api_requestinstead of the missingself._zapimodule to perform the API request.ISSUE TYPE
COMPONENT NAME
Inventory plugin