-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude ubuntu 18.04 from supported OS list #1026
Exclude ubuntu 18.04 from supported OS list #1026
Conversation
34edfb3
to
9b8ff4a
Compare
While I don't disagree with this, I think I would also consider this a breaking change which would mean a major release. @BGmot agree/disagree? |
We just stop testing against not supported OS so no change for users, I'd say it is not a breaking change. @D3DeFi what do you think? |
OK, but if we introduce a change in the future and it breaks it but we never see it because we're not testing...is that still a breaking change? If a change breaks in the forest but no one sees it...is it still a break? |
You are right. Then I guess it's for a major release. |
@masa-orca, we appreciate the contribution but unfortunately given that this is removing functionality, according to the ansible community rules, this would have to be a breaking change that requires a major release. Given that we just did one of those a couple of months ago, I don't see the need to do one right away just to remove something. According to the Zabbix roadmap (https://www.zabbix.com/roadmap#v7_0_LTS), they will be releasing 7.0 at the end of the year and I expect we'll likely do a major release then to depreciate support for 6.2 and 6.4. At that time we'll also remove support for Ubuntu 18.04. |
Hum... I understand what you say. |
Actually, you know what. What's do this the right way. I'm going to go ahead and re-open this ticket. I would suggest that you go through and finish all of the work to actually depreciate Debian 10 though. There are variables in in the vars files that are specific to Debian 10. There's probably (although not sure off hand) some tasks too. Go ahead and clean those up as well. We'll get the PR in a state that its ready to go, but realize we won't actually pull it in until we get to work on 3.0. That work for you? Thanks...Troy |
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION