jira: remove redundant validation #9188
Open
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
| @@ -672,9 +672,6 @@ def operation_attach(self): | |||
| v = self.vars | |||
| filename = v.attachment.get('filename') | |||
| content = v.attachment.get('content') | |||
|
|
|||
| if not any((filename, content)): | |||
| raise ValueError('at least one of filename or content must be provided') | |||
There was a problem hiding this comment.
That's not really equivalent, required=true also accepts an empty string, while this explicitly checks for a non-empty value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In-code validation is never going to fail because
filenameisrequired=true.ISSUE TYPE
COMPONENT NAME
jira