Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xbps: support --rootdir and --repository #9174

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

xbps: support --rootdir and --repository #9174

wants to merge 2 commits into from

Conversation

ssnailed
Copy link

SUMMARY

This MR adds support for the --rootdir and --repository flags of xbps-install, xbps-query and xbps-remove in the xbps module.

This makes it possible to provision new void linux installations ie. from a live image.

Fixes #9173

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

xbps

@ansibullbot
Copy link
Collaborator

cc @dinoocch @the-maldridge
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Nov 22, 2024
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Nov 22, 2024
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Nov 22, 2024
@ssnailed
Copy link
Author

As of now, this is untested. I will test this tomorrow.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Nov 22, 2024
felixfontein
felixfontein reviewed Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/modules/xbps.py
package installation.
The URL can be a URL to a repository for
remote repositories or a path for local repositories.
aliases: [repositories]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally aliases should only be used if absolutely necessary. Here I would remove it, and potentially rename the option to repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-10 Automatically create a backport for the stable-10 branch check-before-release PR will be looked at again shortly before release and merged if possible. feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support --rootdir and --repository flags for xbps
3 participants
@ssnailed @ansibullbot @felixfontein