Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes module_defaults being incorrectly applied to platform actions #511

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fixes module_defaults being incorrectly applied to platform actions #511

wants to merge 1 commit into from

Conversation

NilashishC
Copy link
Contributor

SUMMARY
  • Prevents module_defaults from were being incorrectly applied to the platform action, instead of the concerned module.
  • As an example, setting module_defaults at play level for *_facts did not work due to this issue.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meta/runtime.yml

@github-actions github-actions bot added the bug This issue/PR relates to a bug. label Jan 23, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/bbdb9e96df0c4766892232c7fa3f844c

✔️ ansible-test-network-integration-eos-httpapi-python39-stable215 SUCCESS in 45m 41s
✔️ ansible-test-network-integration-eos-httpapi-python39-stable214 SUCCESS in 44m 57s
✔️ ansible-test-network-integration-eos-httpapi-python39-stable213 SUCCESS in 41m 05s
✔️ ansible-test-network-integration-eos-httpapi-python39-stable212 SUCCESS in 40m 41s
✔️ ansible-test-network-integration-eos-httpapi-python39-stable211 SUCCESS in 40m 22s
✔️ ansible-test-network-integration-eos-network_cli-python39-stable215-scenario01 SUCCESS in 36m 33s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-python39-stable215-scenario02 FAILURE in 38m 52s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-libssh-python39-stable215-scenario01 SUCCESS in 36m 17s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-libssh-python39-stable215-scenario02 FAILURE in 39m 26s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-python39-stable214-scenario01 SUCCESS in 35m 46s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-python39-stable214-scenario02 FAILURE in 38m 38s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-libssh-python39-stable214-scenario01 SUCCESS in 36m 02s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-libssh-python39-stable214-scenario02 FAILURE in 38m 48s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-python39-stable213-scenario01 SUCCESS in 36m 34s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-python39-stable213-scenario02 FAILURE in 37m 25s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-libssh-python39-stable213-scenario01 SUCCESS in 35m 30s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-libssh-python39-stable213-scenario02 FAILURE in 38m 25s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-python39-stable212-scenario01 SUCCESS in 35m 36s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-python39-stable212-scenario02 FAILURE in 38m 08s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-libssh-python39-stable212-scenario01 SUCCESS in 35m 54s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-libssh-python39-stable212-scenario02 FAILURE in 38m 03s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-python39-stable211-scenario01 SUCCESS in 36m 40s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-python39-stable211-scenario02 FAILURE in 37m 43s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-libssh-python39-stable211-scenario01 SUCCESS in 35m 36s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-libssh-python39-stable211-scenario02 FAILURE in 37m 58s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 01s
✔️ ansible-tox-linters SUCCESS in 12m 26s
✔️ ansible-galaxy-importer SUCCESS in 5m 18s

@NilashishC NilashishC marked this pull request as draft January 23, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NilashishC