Add terminal_initial_newline to network_cli module #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrouesnel
force-pushed
the
terminal_initial_newline
branch
from
cc4058f to
e7dd539
Compare
wrouesnel
force-pushed
the
terminal_initial_newline
branch
from
060d618 to
79965ba
Compare
`terminal_initial_newline`, when set to true sends a single newline character to the remote device immediately after initially connecting. This allows network_cli to work with some types of equipment which fail to send any data when SSH connectivity is initially established, such as serial-port multiplexers.
wrouesnel
force-pushed
the
terminal_initial_newline
branch
from
62c54de to
cd23a31
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terminal_initial_newline, when set to true sends a single newline character to the remote device immediately after initially connecting.This allows network_cli to work with some types of equipment which fail to send any data when SSH connectivity is initially established, such as serial-port multiplexers.
SUMMARY
Some types of hardware available over SSH do not send any initial lines of data, causing
network_clito stall when connecting them.terminal_initial_newlinecauses a newline character (i.e. an empty command) to be sent to the remote connection before any other processing takes place, which primes the result buffer for processing other initial prompts.This resolves the issue and allows the module to work when speaking to devices over SSH which do this, such as serial multiplexers which are likely to be hooked up to the serial terminal ports of network hardware.
ISSUE TYPE
COMPONENT NAME
network_cli
ADDITIONAL INFORMATION
There's no relevant command changes here, as it is seamless behind the scenes.